Classmap replacing change str_replace to regex #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, your code wasn't replacing references to the updated class names so I wrote the code myself before yours started working again. Odd.
Anyway, there was still an issue with doubled-up names, so I replaced the str_replace with a regex for more precise replacing.
After the classmap replacer processes each file and theReplacer->replacedClasses
property is populated, the files are revisited and the changes implemented throughout.e.g.
is now
and
is now